fs: fix rmSync to handle non-ASCII characters #61108
Merged
+34
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
joyeecheung
reviewed
Dec 18, 2025
Yeaseen
force-pushed
the
fix-non-ascii-filepath-issue
branch
2 times, most recently
from
0b11867 to
f2996d1
Compare
addaleax
reviewed
Dec 18, 2025
Yeaseen
force-pushed
the
fix-non-ascii-filepath-issue
branch
from
f2996d1 to
475580e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61108 +/- ##
=======================================
Coverage 88.53% 88.53%
=======================================
Files 703 703
Lines 208546 208545 -1
Branches 40217 40221 +4
=======================================
+ Hits 184634 184642 +8
+ Misses 15926 15913 -13
- Partials 7986 7990 +4
🚀 New features to boost your workflow:
|
Update fs.rmSync to properly handle file paths that include non-ASCII characters. This change prevents crashes and errors when attempting to delete files with international or special characters in their names. Add a test in test/parallel to ensure that files with non-ASCII characters can be deleted without issues. This covers cases that previously caused unexpected behavior or crashes on certain file systems. Fixes: nodejs#56049
Yeaseen
force-pushed
the
fix-non-ascii-filepath-issue
branch
from
475580e to
daa7753
Compare
github-actions
bot
removed
the
request-ci
Collaborator
Contributor
Author
|
@jazelly I can’t access Jenkins logs. Can you paste the failing test name/excerpt from |
Member
|
hmm seems like I lost access to jenkins |
Collaborator
joyeecheung
approved these changes
Dec 20, 2025
Contributor
Author
|
@joyeecheung In the previous run, |
Collaborator
lpinca
approved these changes
Dec 22, 2025
anonrig
approved these changes
Dec 25, 2025
avivkeller
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 05d6b9b |
Renegade334
added
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fresh version of PR #56934
Update fs.rmSync to properly handle file paths that include non-ASCII characters. This change prevents crashes and errors when attempting to delete files with international or special characters in their names.
Add a test in test/parallel to ensure that files with non-ASCII characters can be deleted without issues. This covers cases that previously caused unexpected behavior or crashes on certain file systems.
Fixes: #56049
If this gets merged, I will be working on the additional errors part.
@joyeecheung Please review this. Thank you!